[libcxx-commits] [PATCH] D77415: [lit] Move the recursiveExpansionLimit setting to TestingConfig

[Julian Lettner via Phabricator via libcxx-commits]

yln accepted this revision.
yln added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/docs/CommandGuide/lit.rst:457
 
 By default, substitutions are expanded exactly once, so that if e.g. a
+substitution ``%{build}`` is defined in top of another substitution ``%{cxx}``,
----------------
Can we stash these changes until we decided how to deal with prefix matching?


================
Comment at: llvm/docs/CommandGuide/lit.rst:458
 By default, substitutions are expanded exactly once, so that if e.g. a
-substitution ``%build`` is defined in top of another substitution ``%cxx``,
-``%build`` will expand to ``%cxx`` textually, not to what ``%cxx`` expands to.
-However, if the ``recursiveExpansionLimit`` property of the ``LitConfig`` is
-set to a non-negative integer, substitutions will be expanded recursively until
-that limit is reached. It is an error if the limit is reached and expanding
-substitutions again would yield a different result.
+substitution ``%{build}`` is defined in top of another substitution ``%{cxx}``,
+``%{build}`` will expand to ``%{cxx}`` textually, not to what ``%{cxx}`` expands
----------------
Typo: "on top of"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77415/new/

https://reviews.llvm.org/D77415