[libcxx-commits] [PATCH] D77415: [lit] Move the recursiveExpansionLimit setting to TestingConfig

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 3 10:15:15 PDT 2020


ldionne created this revision.
Herald added subscribers: libcxx-commits, broadwaylamb, dexonsmith, jkorous, delcypher.
Herald added projects: libc++, libc++abi.
Herald added a reviewer: libc++.
Herald added a reviewer: libc++abi.
ldionne added reviewers: yln, delcypher.

The LitConfig is shared across the whole test suite. However, since
enabling recursive expansion can be a breaking change for some test
suites, it's important to confine the setting to test suites that
enable it explicitly.

Note that other issues were raised with the way recursiveExpansionLimit
operates. However, this commit simply moves the setting to the right
place -- the mechanism by which it works can be improved independently.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77415

Files:
  libcxx/test/lit.cfg
  libcxx/utils/libcxx/test/format.py
  libcxx/utils/libcxx/test/newformat.py
  libcxxabi/test/lit.cfg
  llvm/docs/CommandGuide/lit.rst
  llvm/utils/lit/lit/LitConfig.py
  llvm/utils/lit/lit/TestRunner.py
  llvm/utils/lit/lit/TestingConfig.py
  llvm/utils/lit/tests/Inputs/shtest-recursive-substitution/does-not-substitute-within-limit/lit.cfg
  llvm/utils/lit/tests/Inputs/shtest-recursive-substitution/negative-integer/lit.cfg
  llvm/utils/lit/tests/Inputs/shtest-recursive-substitution/not-an-integer/lit.cfg
  llvm/utils/lit/tests/Inputs/shtest-recursive-substitution/set-to-none/lit.cfg
  llvm/utils/lit/tests/Inputs/shtest-recursive-substitution/substitutes-within-limit/lit.cfg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77415.254849.patch
Type: text/x-patch
Size: 10630 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200403/e26eb069/attachment-0001.bin>


More information about the libcxx-commits mailing list