[libcxx-commits] [libcxxabi] c3b5c98 - [libc++abi] NFC: Add link to review in workaround comment

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2020-04-02T13:20:23-04:00
New Revision: c3b5c98e39533302d27f13895dad1e7b2e425f68

URL: https://github.com/llvm/llvm-project/commit/c3b5c98e39533302d27f13895dad1e7b2e425f68
DIFF: https://github.com/llvm/llvm-project/commit/c3b5c98e39533302d27f13895dad1e7b2e425f68.diff

LOG: [libc++abi] NFC: Add link to review in workaround comment

To avoid wasting the valuable time of contributors, add a link to a
blocked review to document additional issues with the removal of some
GCC 4.9 workaround.

Added: 
    

Modified: 
    libcxxabi/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libcxxabi/CMakeLists.txt b/libcxxabi/CMakeLists.txt
index a58789f5bfb7..a269806891d9 100644
--- a/libcxxabi/CMakeLists.txt
+++ b/libcxxabi/CMakeLists.txt
@@ -69,6 +69,7 @@ option(LIBCXXABI_BUILD_EXTERNAL_THREAD_LIBRARY
 # FIXME: This option should default to off. Unfortunatly GCC 4.9 fails to link
 # programs to due undefined references to new/delete in libc++abi. Once this
 # has been fixed or worked around the default value should be changed.
+# See https://reviews.llvm.org/D68269 for more details.
 option(LIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS
     "Build libc++abi with definitions for operator new/delete. Normally libc++
     provides these definitions" ON)