[libcxx-commits] [libcxx] r372963 - [libcxx] Do not implicitly #include assert.h
David Zarzycki via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Sep 26 04:12:29 PDT 2019
Author: davezarzycki
Date: Thu Sep 26 04:12:29 2019
New Revision: 372963
URL: http://llvm.org/viewvc/llvm-project?rev=372963&view=rev
Log:
[libcxx] Do not implicitly #include assert.h
Users should only get the assert() macros if they explicitly include
them.
Found after switching from the GNU C++ stdlib to the LLVM C++ stdlib.
Added:
libcxx/trunk/test/libcxx/no_assert_include.sh.cpp
Modified:
libcxx/trunk/include/experimental/coroutine
libcxx/trunk/include/memory
libcxx/trunk/test/std/experimental/simd/simd.cons/broadcast.pass.cpp
libcxx/trunk/test/std/experimental/simd/simd.cons/generator.pass.cpp
libcxx/trunk/test/std/experimental/simd/simd.cons/load.pass.cpp
libcxx/trunk/test/std/experimental/simd/simd.mem/load.pass.cpp
libcxx/trunk/test/std/experimental/simd/simd.mem/store.pass.cpp
Modified: libcxx/trunk/include/experimental/coroutine
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/experimental/coroutine?rev=372963&r1=372962&r2=372963&view=diff
==============================================================================
--- libcxx/trunk/include/experimental/coroutine (original)
+++ libcxx/trunk/include/experimental/coroutine Thu Sep 26 04:12:29 2019
@@ -51,7 +51,6 @@ template <class P> struct hash<coroutine
#include <functional>
#include <memory> // for hash<T*>
#include <cstddef>
-#include <cassert>
#include <__debug>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
Modified: libcxx/trunk/include/memory
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/memory?rev=372963&r1=372962&r2=372963&view=diff
==============================================================================
--- libcxx/trunk/include/memory (original)
+++ libcxx/trunk/include/memory Thu Sep 26 04:12:29 2019
@@ -662,7 +662,6 @@ void* align(size_t alignment, size_t siz
#include <tuple>
#include <stdexcept>
#include <cstring>
-#include <cassert>
#if !defined(_LIBCPP_HAS_NO_ATOMIC_HEADER)
# include <atomic>
#endif
Added: libcxx/trunk/test/libcxx/no_assert_include.sh.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/no_assert_include.sh.cpp?rev=372963&view=auto
==============================================================================
--- libcxx/trunk/test/libcxx/no_assert_include.sh.cpp (added)
+++ libcxx/trunk/test/libcxx/no_assert_include.sh.cpp Thu Sep 26 04:12:29 2019
@@ -0,0 +1,171 @@
+// -*- C++ -*-
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// Ensure that none of the standard C++ headers implicitly include cassert or
+// assert.h (because assert() is implemented as a macro).
+
+// RUN: %compile -fsyntax-only
+
+// Prevent <ext/hash_map> from generating deprecated warnings for this test.
+#if defined(__DEPRECATED)
+#undef __DEPRECATED
+#endif
+
+// Top level headers
+#include <algorithm>
+#include <any>
+#include <array>
+#ifndef _LIBCPP_HAS_NO_THREADS
+#include <atomic>
+#endif
+#include <bit>
+#include <bitset>
+#include <ccomplex>
+#include <cctype>
+#include <cerrno>
+#include <cfenv>
+#include <cfloat>
+#include <charconv>
+#include <chrono>
+#include <cinttypes>
+#include <ciso646>
+#include <climits>
+#include <clocale>
+#include <cmath>
+#include <codecvt>
+#include <compare>
+#include <complex>
+#include <complex.h>
+#include <condition_variable>
+#include <csetjmp>
+#include <csignal>
+#include <cstdarg>
+#include <cstdbool>
+#include <cstddef>
+#include <cstdint>
+#include <cstdio>
+#include <cstdlib>
+#include <cstring>
+#include <ctgmath>
+#include <ctime>
+#include <ctype.h>
+#include <cwchar>
+#include <cwctype>
+#include <deque>
+#include <errno.h>
+#include <exception>
+#include <execution>
+#include <fenv.h>
+#include <filesystem>
+#include <float.h>
+#include <forward_list>
+#include <fstream>
+#include <functional>
+#ifndef _LIBCPP_HAS_NO_THREADS
+#include <future>
+#endif
+#include <initializer_list>
+#include <inttypes.h>
+#include <iomanip>
+#include <ios>
+#include <iosfwd>
+#include <iostream>
+#include <istream>
+#include <iterator>
+#include <limits>
+#include <limits.h>
+#include <list>
+#include <locale>
+#include <locale.h>
+#include <map>
+#include <math.h>
+#include <memory>
+#ifndef _LIBCPP_HAS_NO_THREADS
+#include <mutex>
+#endif
+#include <new>
+#include <numeric>
+#include <optional>
+#include <ostream>
+#include <queue>
+#include <random>
+#include <ratio>
+#include <regex>
+#include <scoped_allocator>
+#include <set>
+#include <setjmp.h>
+#ifndef _LIBCPP_HAS_NO_THREADS
+#include <shared_mutex>
+#endif
+#include <span>
+#include <sstream>
+#include <stack>
+#include <stdbool.h>
+#include <stddef.h>
+#include <stdexcept>
+#include <stdint.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <streambuf>
+#include <string>
+#include <string.h>
+#include <string_view>
+#include <strstream>
+#include <system_error>
+#include <tgmath.h>
+#ifndef _LIBCPP_HAS_NO_THREADS
+#include <thread>
+#endif
+#include <tuple>
+#include <typeindex>
+#include <typeinfo>
+#include <type_traits>
+#include <unordered_map>
+#include <unordered_set>
+#include <utility>
+#include <valarray>
+#include <variant>
+#include <vector>
+#include <version>
+#include <wchar.h>
+#include <wctype.h>
+
+// experimental headers
+#if __cplusplus >= 201103L
+#include <experimental/algorithm>
+#if defined(__cpp_coroutines)
+#include <experimental/coroutine>
+#endif
+#include <experimental/deque>
+#include <experimental/filesystem>
+#include <experimental/forward_list>
+#include <experimental/functional>
+#include <experimental/iterator>
+#include <experimental/list>
+#include <experimental/map>
+#include <experimental/memory_resource>
+#include <experimental/propagate_const>
+#include <experimental/regex>
+#include <experimental/simd>
+#include <experimental/set>
+#include <experimental/string>
+#include <experimental/type_traits>
+#include <experimental/unordered_map>
+#include <experimental/unordered_set>
+#include <experimental/utility>
+#include <experimental/vector>
+#endif // __cplusplus >= 201103L
+
+// extended headers
+#include <ext/hash_map>
+#include <ext/hash_set>
+
+#ifdef assert
+#error "Do not include cassert or assert.h in standard header files"
+#endif
Modified: libcxx/trunk/test/std/experimental/simd/simd.cons/broadcast.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/experimental/simd/simd.cons/broadcast.pass.cpp?rev=372963&r1=372962&r2=372963&view=diff
==============================================================================
--- libcxx/trunk/test/std/experimental/simd/simd.cons/broadcast.pass.cpp (original)
+++ libcxx/trunk/test/std/experimental/simd/simd.cons/broadcast.pass.cpp Thu Sep 26 04:12:29 2019
@@ -13,8 +13,9 @@
// [simd.class]
// template <class U> simd(U&& value);
-#include <cstdint>
#include <experimental/simd>
+#include <cstdint>
+#include <cassert>
#include "test_macros.h"
Modified: libcxx/trunk/test/std/experimental/simd/simd.cons/generator.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/experimental/simd/simd.cons/generator.pass.cpp?rev=372963&r1=372962&r2=372963&view=diff
==============================================================================
--- libcxx/trunk/test/std/experimental/simd/simd.cons/generator.pass.cpp (original)
+++ libcxx/trunk/test/std/experimental/simd/simd.cons/generator.pass.cpp Thu Sep 26 04:12:29 2019
@@ -15,6 +15,7 @@
#include <experimental/simd>
#include <cstdint>
+#include <cassert>
#include "test_macros.h"
Modified: libcxx/trunk/test/std/experimental/simd/simd.cons/load.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/experimental/simd/simd.cons/load.pass.cpp?rev=372963&r1=372962&r2=372963&view=diff
==============================================================================
--- libcxx/trunk/test/std/experimental/simd/simd.cons/load.pass.cpp (original)
+++ libcxx/trunk/test/std/experimental/simd/simd.cons/load.pass.cpp Thu Sep 26 04:12:29 2019
@@ -13,8 +13,9 @@
// [simd.class]
// template <class U, class Flags> simd(const U* mem, Flags f);
-#include <cstdint>
#include <experimental/simd>
+#include <cstdint>
+#include <cassert>
#include "test_macros.h"
Modified: libcxx/trunk/test/std/experimental/simd/simd.mem/load.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/experimental/simd/simd.mem/load.pass.cpp?rev=372963&r1=372962&r2=372963&view=diff
==============================================================================
--- libcxx/trunk/test/std/experimental/simd/simd.mem/load.pass.cpp (original)
+++ libcxx/trunk/test/std/experimental/simd/simd.mem/load.pass.cpp Thu Sep 26 04:12:29 2019
@@ -15,6 +15,7 @@
#include <experimental/simd>
#include <cstdint>
+#include <cassert>
#include "test_macros.h"
Modified: libcxx/trunk/test/std/experimental/simd/simd.mem/store.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/experimental/simd/simd.mem/store.pass.cpp?rev=372963&r1=372962&r2=372963&view=diff
==============================================================================
--- libcxx/trunk/test/std/experimental/simd/simd.mem/store.pass.cpp (original)
+++ libcxx/trunk/test/std/experimental/simd/simd.mem/store.pass.cpp Thu Sep 26 04:12:29 2019
@@ -15,6 +15,7 @@
#include <experimental/simd>
#include <cstdint>
+#include <cassert>
#include "test_macros.h"
More information about the libcxx-commits
mailing list