[libcxx-commits] [PATCH] D65161: [libc++] Implement LWG 2510

[Louis Dionne via Phabricator via libcxx-commits]

ldionne reopened this revision.
ldionne added a comment.

This was reverted in r372832. I'm waiting to see the resolution of https://bugs.llvm.org/show_bug.cgi?id=43454 before I know what to do.



================
Comment at: libcxx/test/std/utilities/memory/allocator.tag/allocator_arg.fail.cpp:19
 
-int main(int, char**)
-{
-    test(std::allocator_arg);
+std::allocator_arg_t f() { return {}; } // expected-error 1 {{chosen constructor is explicit in copy-initialization}}
 
----------------
zoecarver wrote:
> If we are keeping this test we should update this function to `return std:: allocator_arg_t ()`. 
The whole point of this test is to exercise the error caused by the non-explicit copy-initialization. I'm not sure I understand your comment.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65161/new/

https://reviews.llvm.org/D65161