[libcxx-commits] [PATCH] D67667: Add benchmarks for string assign methods

[Martijn Vels via Phabricator via libcxx-commits]

mvels marked an inline comment as done.
mvels added inline comments.


================
Comment at: libcxx/benchmarks/string.bench.cpp:267
+    constexpr size_t kNumStrings = 4 << 10;
+    std::string strings[kNumStrings];
+    while (state.KeepRunningBatch(kNumStrings)) {
----------------
EricWF wrote:
> Escape this memory with `DoNotOptimize` before entering the loop.
This is done already per batch right after the batch is cleared, unless I miss something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67667/new/

https://reviews.llvm.org/D67667