[libcxx-commits] [PATCH] D67316: Remove ::gets for FreeBSD 13 and later

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.

LGTM with the one change I suggested.



================
Comment at: include/__config:1147
 
+// Some systems do not provide gets() in their C library, for security reasons.
+#if defined(_LIBCPP_MSVCRT) || (defined(__FreeBSD__) && __FreeBSD__ >= 13)
----------------
Even better would be to have a way to define it at build time as well.

So wrap this in 
```
#ifndef _LIBCPP_C_HAS_NO_GETS
...
#endif
```

and then commit it.



Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67316/new/

https://reviews.llvm.org/D67316