[libcxx-commits] [PATCH] D66970: [libc++] Explicitly provide a list of exported symbols for libc++

Wed Sep 4 09:05:46 PDT 2019

ldionne added a comment.

In D66970#1657660 <https://reviews.llvm.org/D66970#1657660>, @mclow.lists wrote:

> I see maintaining an explicit list of exports as an ongoing time sink - are you sure this is the the direction that we want to take?

This list only contains symbols that we want to export from the dylib, not all symbols. And we already need to update the ABI list (so it passes the `check-cxx-abilist` test) whenever we add a new symbol to the dylib. So I think this isn't going to be a huge time sink on top of what we already do, but I could be wrong. On the other hand, it has the benefit that we will be able to remove all visibility annotations from the libc++ sources.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66970/new/

https://reviews.llvm.org/D66970