[libcxx-commits] [PATCH] D67052: Add reference type transformation builtins

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1095
+  default:
+    assert(false && "Not a reference type specifier");
+  }
----------------
Mordante wrote:
> Wouldn't it be better to use `llvm_unreachable("Not a reference type specifier");`
> Maybe also move this line out of the switch, allowing the compiler to warn about not handled enumeration values.
I'll update it to use `llvm_unreachable` but, I don't think we want the compiler to warn about unhandled enumeration values. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67052/new/

https://reviews.llvm.org/D67052