[libcxx-commits] [PATCH] D67086: Implement std::basic_syncbuf (p0053)

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked 4 inline comments as done.
zoecarver added inline comments.


================
Comment at: libcxx/include/syncstream:15
+    syncstream synopsis
+
+*/
----------------
Oops. I'll add this. 


================
Comment at: libcxx/test/std/input.output/sncstream/syncbuf/cons.pass.cpp:70
+    // LWG issue?
+    // assert(buff1.rdbuf()->pbase() == buff1.rdbuf()->pptr());
+}
----------------
I was a bit confused [[ http://eel.is/c++draft/syncstream#syncbuf.cons-6 | by this. ]] I am going to email Peter after I figure out what I think this //should// say.


================
Comment at: libcxx/test/std/input.output/sncstream/syncbuf/members.pass.cpp:52
+template<class CharT>
+void test_emit()
+{
----------------
I'm planning on testing this more extensively and adding thread tests. What is the best way to test with threads (our current thread tests seem to be lacking)? 


================
Comment at: libcxx/test/std/input.output/sncstream/syncbuf/virtuals.pass.cpp:54
+    std::basic_ostringstream<CharT> ss;
+    test_buf<CharT> *base = reinterpret_cast<test_buf<CharT>*>(ss.rdbuf());
+    std::allocator<CharT> alloc;
----------------
This is bad. I'm planning on updating it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67086/new/

https://reviews.llvm.org/D67086