[libcxx-commits] [PATCH] D69692: [libcxx][cmake]Fixing ordering in setting SUPPORTS_DIALECT_NAME/SUPPORTS_DIALECT_NAME_MSVC.

[Puyan Lotfi via Phabricator via libcxx-commits]

plotfi created this revision.
plotfi added reviewers: beanz, compnerd.
Herald added subscribers: libcxx-commits, ldionne, christof, mgorny.
Herald added a reviewer: EricWF.
Herald added a project: libc++.
plotfi abandoned this revision.
Herald added a reviewer: mclow.lists.

I think the current ordering clobbers LIBCXX_STANDARD_VER and makes it so SUPPORTS_DIALECT_NAME_MSVC and SUPPORTS_DIALECT_NAME are both false.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69692

Files:
  libcxx/CMakeLists.txt


Index: libcxx/CMakeLists.txt
===================================================================
--- libcxx/CMakeLists.txt
+++ libcxx/CMakeLists.txt
@@ -526,8 +526,8 @@
     set(LIBCXX_STANDARD_VER c++11 CACHE STRING "internal option to change build dialect")
   endif()
   target_add_compile_flags_if_supported(${target} PRIVATE -std=${LIBCXX_STANDARD_VER})
-  target_add_compile_flags_if_supported(${target} PRIVATE "/std:${LIBCXX_STANDARD_VER}")
   mangle_name("LIBCXX_SUPPORTS_STD_EQ_${LIBCXX_STANDARD_VER}_FLAG" SUPPORTS_DIALECT_NAME)
+  target_add_compile_flags_if_supported(${target} PRIVATE "/std:${LIBCXX_STANDARD_VER}")
   mangle_name("LIBCXX_SUPPORTS_STD_COLON_${LIBCXX_STANDARD_VER}_FLAG" SUPPORTS_DIALECT_NAME_MSVC)
   if(NOT ${SUPPORTS_DIALECT_NAME} AND NOT ${SUPPORTS_DIALECT_NAME_MSVC})
     if(NOT "${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC" AND NOT "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69692.227376.patch
Type: text/x-patch
Size: 910 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20191031/b36fdbaf/attachment.bin>