[libcxx-commits] [PATCH] D69504: [libunwind] [Windows] Add a log message if EnumProcessModules fails

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 31 00:39:44 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rG08c7ff99e138: [libunwind] [Windows] Add a log message if EnumProcessModules fails (authored by mstorsjo).
Herald added a project: libc++.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69504/new/

https://reviews.llvm.org/D69504

Files:
  libunwind/src/AddressSpace.hpp


Index: libunwind/src/AddressSpace.hpp
===================================================================
--- libunwind/src/AddressSpace.hpp
+++ libunwind/src/AddressSpace.hpp
@@ -433,8 +433,12 @@
   HANDLE process = GetCurrentProcess();
   DWORD needed;
 
-  if (!EnumProcessModules(process, mods, sizeof(mods), &needed))
+  if (!EnumProcessModules(process, mods, sizeof(mods), &needed)) {
+    DWORD err = GetLastError();
+    _LIBUNWIND_TRACE_UNWINDING("findUnwindSections: EnumProcessModules failed, "
+                               "returned error %d", (int)err);
     return false;
+  }
 
   for (unsigned i = 0; i < (needed / sizeof(HMODULE)); i++) {
     PIMAGE_DOS_HEADER pidh = (PIMAGE_DOS_HEADER)mods[i];


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69504.227232.patch
Type: text/x-patch
Size: 717 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20191031/2ddd099a/attachment.bin>


More information about the libcxx-commits mailing list