[libcxx-commits] [PATCH] D69286: I implemented the features listed in this document: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0616r0.pdf and built libc++ using ninja without any errors/warnings. I Also ran the test suite it using `lit` and passed all the unit tests.

Fri Oct 25 17:15:06 PDT 2019

EricWF added a comment.

Please correct the patch description and title to be clearer and not all on one line.

Also, any change to libc++ requires tests that demonstrate the changed behavior. The test should fail without your change and pass with it.
Please add some tests.

Also, please remove any unintentional changes from the patch under review.

================
Comment at: libcxx/CMakeLists.txt:539
+option (FORCE_COLORED_OUTPUT "Always produce ANSI-colored output (GNU/Clang only)." FALSE)
+if (${FORCE_COLORED_OUTPUT})
+    if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
----------------
This change is unrelated to this patch and shouldn't be included.

================
Comment at: libcxx/include/numeric:146
 #include <iterator>
+#if _LIBCPP_STD_VER > 17 
 #include <limits> // for numeric_limits
----------------
Just always include limits. No need to guard this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69286/new/

https://reviews.llvm.org/D69286