[libcxx-commits] [PATCH] D69170: [libcxx] [test] Run `chmod +x` on executables when testing via SSH

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb marked 2 inline comments as done.
broadwaylamb added a comment.

@ldionne if everything is good, can we land this?



================
Comment at: libcxx/utils/libcxx/test/executor.py:203
+
+        remote_cmd = ' '.join(cmd)
+        remote_cmd = (' '.join(export_cmd) + ' && ' + remote_cmd) \
----------------
ldionne wrote:
> This seems clearer to me:
> 
> ```
> if export_cmd:
>   remote_cmd = ' '.join(export_cmd) + ' && ' + remote_cmd
> ```
Oh. Of course. Updated accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69170/new/

https://reviews.llvm.org/D69170