[libcxx-commits] [PATCH] D69170: [libcxx] [test] Run `chmod +x` on executables when testing via SSH
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Oct 24 15:49:02 PDT 2019
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
LGTM with the requested change.
================
Comment at: libcxx/utils/libcxx/test/executor.py:203
+
+ remote_cmd = ' '.join(cmd)
+ remote_cmd = (' '.join(export_cmd) + ' && ' + remote_cmd) \
----------------
This seems clearer to me:
```
if export_cmd:
remote_cmd = ' '.join(export_cmd) + ' && ' + remote_cmd
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69170/new/
https://reviews.llvm.org/D69170
More information about the libcxx-commits
mailing list