[libcxx-commits] [PATCH] D69344: [libcxx] Add move constructor to compressed pair

Thu Oct 24 09:34:44 PDT 2019

zoecarver added a comment.

> You need to default it in both bases and in the compressed pair itself.

Yes, you're right. That fixed it.

> I don't think we care about move-only types in C++03.

Depends if we want to resolve 2802 in C++03. I think we do, if for no other reason than we don't want to have half a dozen more `#ifndef` blocks.

> Also, did you test this change? Because adding a move constructor to compressed pair suppresses the copy constructor and make the type always move only.

It seemed to pass the memory tests. I also defaulted the copy constructor so, that shouldn't be an issue anymore.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69344/new/

https://reviews.llvm.org/D69344