[libcxx-commits] [PATCH] D66177: Update shared_ptr's constructor

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 22 16:04:15 PDT 2019


zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: libcxx/include/memory:3917
+    {
+        try {
+            typedef __shared_ptr_pointer<_Yp*, _Deleter, _Alloc> _CT;
----------------
I'm going to move the try-catch-blocks out of these two members and into the initializers they're used in. This should help with codegen.

Also, I forgot to wrap these in the `#if`s. 


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66177/new/

https://reviews.llvm.org/D66177





More information about the libcxx-commits mailing list