[libcxx-commits] [PATCH] D69195: [libcxx] Fix .gitignore to not exclude test directories

Fri Oct 18 14:32:23 PDT 2019

smeenai marked an inline comment as done.
smeenai added inline comments.

================
Comment at: libcxx/.gitignore:29
 *.manifest
 *.spec
+# Don't ignore a directory ending in .spec, since we have several of those in
----------------
ldionne wrote:
> Why don't we just remove this? I don't understand what it's useful for, as I don't understand the comment just above.
This seems like it might have been taken from some generic `.gitignore` file? I'm happy to remove the PyInstaller bits entirely though if that doesn't seem like something that's relevant for libc++.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69195/new/

https://reviews.llvm.org/D69195