[libcxx-commits] [PATCH] D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD

[Dimitry Andric via Phabricator via libcxx-commits]

dim marked an inline comment as done.
dim added inline comments.


================
Comment at: include/__config:1169
+#  if defined(_LIBCPP_MSVCRT) || \
+      (defined(__FreeBSD__) && __FreeBSD_version >= 1300043)
 #    define _LIBCPP_C_HAS_NO_GETS
----------------
ldionne wrote:
> Shouldn't this say `defined(__FreeBSD_version) && __FreeBSD_version >= 1300043`?
Good one; functionally it won't matter, since <osreldate.h>'s only function is to `#define` `__FreeBSD_version`, and it will always be defined.  But I can see that it might be confusing to read.



Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69174/new/

https://reviews.llvm.org/D69174