[libcxx-commits] [PATCH] D68840: [libc++][P0980] Marked member functions move/copy/assign of char_traits constexpr.

[Michael Park via Phabricator via libcxx-commits]

mpark marked 2 inline comments as done.
mpark added inline comments.


================
Comment at: libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char/assign3.pass.cpp:20
 
-int main(int, char**)
+TEST_CONSTEXPR_CXX20 bool test()
 {
----------------
ldionne wrote:
> ldionne wrote:
> > Did you forget to include the change to `test_macros.h` (or whatever file) where you add `TEST_CONSTEXPR_CXX20`? I can't find it.
> > 
> > Also, I would suggest `TEST_CONSTEXPR_AFTER_CXX17`, to mirror the checks we usually make (which are always of the form `#if STD > 17`.
> > Did you forget to include the change to `test_macros.h` (or whatever file) where you add `TEST_CONSTEXPR_CXX20`? I can't find it.
> 
> Nevermind this, I just saw the other review. My bad.
> 
> 
> > Also, I would suggest `TEST_CONSTEXPR_AFTER_CXX17`, to mirror the checks we usually make (which are always of the form `#if STD > 17`.
> 
> Forget this, I'll comment on D68837 instead.
> 
Perhaps you decided to drop this issue since I don't see a follow-up comment on D68837.
Just as a note, I went with `TEST_CONSTEXPR_CXX20` to be consistent with `TEST_CONSTEXPR_CXX14`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68840/new/

https://reviews.llvm.org/D68840