[libcxx-commits] [PATCH] D66262: Constrain tuple/unique_ptr move constructors (2899)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/memory:2555
   unique_ptr& operator=(unique_ptr const&) = delete;
-#endif
-
----------------
zoecarver wrote:
> mclow.lists wrote:
> > Ok, this is just weird.  Everywhere else in libc++, we avoid using `= delete` in C++03 mode, because it's not a thing.
> > We even have a macro for it in `__config`:
> > ```
> > #ifdef _LIBCPP_CXX03_LANG
> > #  define _LIBCPP_EQUAL_DELETE
> > #else
> > #  define _LIBCPP_EQUAL_DELETE = delete
> > #endif
> > ```
> > 
> > And yet, here (twice!) we only do this for C++03.
> > @EricWF added this in https://llvm.org/r364161; so I think he should explain.
> Looks like it was just after we dropped support for GCC 4. He was probably just removing some of the C++03 clutter & cleaning up our implementation. But, I'll wait for him to respond. 
Ping @EricWF 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66262/new/

https://reviews.llvm.org/D66262