[libcxx-commits] [PATCH] D68880: [libc++] Use generator expression in Linker script generation

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D68880#1706558 <https://reviews.llvm.org/D68880#1706558>, @phosek wrote:

> In D68880#1706543 <https://reviews.llvm.org/D68880#1706543>, @phosek wrote:
>
> > In D68880#1706330 <https://reviews.llvm.org/D68880#1706330>, @ldionne wrote:
> >
> > > @phosek Can you please confirm this also fixes your issue in the Runtimes build?
> >
> >
> > I got the following error:
> >
> >   Error evaluating generator expression:
> >   
> >     $<TARGET_EXISTS:unwind_shared>
> >   
> >   Expression did not evaluate to a known generator expression
> >   
>
>
> It seems like `TARGET_EXISTS` was only introduced in CMake 3.12 but I have 3.10 on my workstation. I'll try to upgrade my CMake and try again, but this may prevent us from rolling this out to LLVM which is still requiring 3.4.


With CMake 3.13 it works!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68880/new/

https://reviews.llvm.org/D68880