[libcxx-commits] [PATCH] D68879: P1152R4: Fix deprecation warnings in libc++ testsuite and in uses of is_invocable that would internally conjure up a deprecated function type.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/__config:966
 
+// Macros to enter and leave a state where deprecation warnings are suppressed.
+#if !defined(_LIBCPP_SUPPRESS_DEPRECATED_PUSH) && \
----------------
Please document that we're talking about compiler deprecation warnings, otherwise this can be confused as also turning off library deprecation warnings. Ignoring `-Wdeprecated` won't have that effect, right?

```
// Macros to enter and leave a state where compiler deprecation warnings are suppressed. This doesn't impact library deprecation warnings.
```

Or something along those lines.



================
Comment at: libcxx/include/__config:969
+    (defined(_LIBCPP_COMPILER_CLANG) || defined(_LIBCPP_COMPILER_GCC))
+#define _LIBCPP_SUPPRESS_DEPRECATED_PUSH \
+  _Pragma("GCC diagnostic push") \
----------------
Please indent nested `#defines`:

```
#  define _LIBCPP_SUPPRESS_DEPRECATED_PUSH
```



================
Comment at: libcxx/include/type_traits:1123
+// Suppress deprecation notice for volatile-qualified return type.
+_LIBCPP_SUPPRESS_DEPRECATED_PUSH
 template <class _Tp> _Tp&& __declval(int);
----------------
Wait, I don't see any `volatile` qualification here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68879/new/

https://reviews.llvm.org/D68879