[libcxx-commits] [PATCH] D68275: [libcxx] [test] Query the target platform, not the host one

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb updated this revision to Diff 224636.
broadwaylamb added a comment.

Don't leak host environment when executing tests on a remote target.

The execution environment that is built in the `Configuration` object (I'm referring to `self.exec_env` in `config.py`) doesn't pick up the current host environment anymore, but rather is built from scratch, and is only merged with the current environment by an Executor right before running the test:

- The LocalExecutor just merges it with the host environment

- The SSHExecutor passes the execution environment to the target as-is, except for the PATH variable. We update the target PATH variable instead of overwriting it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68275/new/

https://reviews.llvm.org/D68275

Files:
  libcxx/utils/libcxx/test/config.py
  libcxx/utils/libcxx/test/executor.py
  libcxx/utils/libcxx/test/target_info.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68275.224636.patch
Type: text/x-patch
Size: 5954 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20191011/b25b6a6b/attachment-0001.bin>