[libcxx-commits] [PATCH] D68855: [libunwind] Refactor CMake flag checks to match libc++ and libc++abi

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 10 19:49:38 PDT 2019


phosek created this revision.
phosek added reviewers: ldionne, beanz, smeenai.
Herald added subscribers: libcxx-commits, mstorsjo, jfb, dexonsmith, christof, mgorny.
Herald added a reviewer: EricWF.

libunwind was using its own set of macros/functions for flag checking
which was similar but different from libc++ and libc++abi. This made
it difficult to replicate the same checks across projects, in fact
there were some checks that appear to have been copy & pasted from
another project and that were broken in the standalone libunwind build.
This change refactors flag checks to match libc++ and libc++abi using
a copy of HandleLibunwindFlags.cmake which is derived from the versions
used by the other projects. This also paves a road to deduplicating and
unifying HandleLibunwindFlags.cmake, HandleLibcxxabiFlags.cmake and
HandleLibcxxFlags.cmake post monorepo switch.


Repository:
  rUNW libunwind

https://reviews.llvm.org/D68855

Files:
  libunwind/CMakeLists.txt
  libunwind/cmake/Modules/HandleLibunwindFlags.cmake
  libunwind/cmake/config-ix.cmake
  libunwind/src/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68855.224530.patch
Type: text/x-patch
Size: 25756 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20191011/c1fd2d2e/attachment-0001.bin>


More information about the libcxx-commits mailing list