[libcxx-commits] [PATCH] D68791: [libc++] Fix linker script generation

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/cmake/Modules/DefineLinkerScript.cmake:34
     foreach(lib IN LISTS interface_libs)
-      if (TARGET "${lib}")
+      if (TARGET "${lib}" OR
+          (${lib} MATCHES "cxxabi(_static|_shared)?" AND HAVE_LIBCXXABI) OR
----------------
How can it be that `${lib}` is equal to `cxxabi_static` or `cxxabi_shared`, but it's not a target? The same applies to the `unwind_xxx` targets. I think this has to do with how you configure your build for Fuchsia with `HAVE_LIBCXXABI`. Can you show me exactly what arguments are used in the CMake invocation?

TBH, I'd like to better understand the purpose of `HAVE_LIBCXXABI` and `HAVE_LIBUNWIND`, since those certainly look like slight hacks that would be nice to support better.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68791/new/

https://reviews.llvm.org/D68791