[libcxx-commits] [PATCH] D68343: [libc++] Move the linker script generation step to CMake

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D68343#1703942 <https://reviews.llvm.org/D68343#1703942>, @ldionne wrote:

> In D68343#1702521 <https://reviews.llvm.org/D68343#1702521>, @phosek wrote:
>
> > This seems to have broke our build, I checked the generated linker script and it has the following format:
> >
> >   INPUT(libc++.so.2 -lunwind_shared -lcxxabi_shared)
> >
> >
> > libunwind and libc++abi dependencies are incorrect, it should be:
> >
> >   INPUT(libc++.so.2 -lunwind -lc++abi)
> >
>
>
> How do you configure your build? The paths were certainly correct when I tested this on Linux. I think this may have something to do with the fact that you use the (kind of hacky) `HAVE_LIBCXXABI` switch. If you let me know how you configure your build, I'll try to repro and fix it.


Oops, I didn't reload before replying. I'll follow up on https://reviews.llvm.org/D68791.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68343/new/

https://reviews.llvm.org/D68343