[libcxx-commits] [PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 9 06:44:28 PDT 2019


Quuxplusone added inline comments.


================
Comment at: test/std/containers/unord/unord.map/unord.map.cnstr/deduct.pass.cpp:70
+#pragma warning(disable: 4244) // '%s': conversion from '%s' to '%s', possible loss of data
+#endif // TEST_COMPILER_C1XX
+
----------------
Alternatively, if you wanted to change the instances of `hash<short>` to `hash<>`, that would be fine with me. (Just as long as it's something distinguishable from the default of `hash<int>`.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68681/new/

https://reviews.llvm.org/D68681





More information about the libcxx-commits mailing list