[libcxx-commits] [PATCH] D68343: [libc++] Move the linker script generation step to CMake

[Vitaly Buka via Phabricator via libcxx-commits]

vitalybuka marked an inline comment as done.
vitalybuka added inline comments.


================
Comment at: libcxx/cmake/Modules/DefineLinkerScript.cmake:41
+  endif()
+  list(JOIN link_libraries " " link_libraries)
+
----------------
vitalybuka wrote:
> https://llvm.org/docs/CMake.html min requirement is 3.4.3
> but JOIN is 3.4.12
I see a fix r374120


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68343/new/

https://reviews.llvm.org/D68343