[libcxx-commits] [PATCH] D68617: Optimize copy constructor

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 7 18:25:30 PDT 2019


mclow.lists added a comment.

A couple of things:

1. Can you give your patches a better title?  "//Optimize copy constructor//" is not very informative. Which copy constructor?
2. What does this do it the dylib - where `basic_string<char>` and `basic_string<wchar_t>` are externally instantiated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68617/new/

https://reviews.llvm.org/D68617





More information about the libcxx-commits mailing list