[libcxx-commits] [PATCH] D68269: [libc++abi] Do not define new/delete by default

Fri Oct 4 13:08:18 PDT 2019

srhines added a comment.

In D68269#1693496 <https://reviews.llvm.org/D68269#1693496>, @danalbert wrote:

> > If the Android and FreeBSD folks are ok with this, I'm fine with it
>
> Fine for Android for at least the platform and the NDK (we don't actually build with CMake in those cases). +srhines just in case there's another case I don't know about.

I don't think there are any other problems for us. When we build libc++ as part of the toolchain build, it is primarily to be used for the Linux host, because external/libcxx handles our on-device cases. I looked at our build rules briefly to make sure that everything should be fine, and agree with Dan.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68269/new/

https://reviews.llvm.org/D68269