[libcxx-commits] [PATCH] D68075: Do not #error if no OS is #defined

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D68075#1695110 <https://reviews.llvm.org/D68075#1695110>, @ldionne wrote:

> I kinda like the suggestion. I'm pretty confident we don't support compilers that don't implement `__has_include` anyway (maybe we technically do, but I'm sure nothing good happens in that case).


However, even your suggestion doesn't answer the question of what's the purpose of setting `-DLIBCXX_ENABLE_THREADS=OFF` if we detect it automatically in the headers anyway. If we go down your route, I'd drop `-DLIBCXX_ENABLE_THREADS` completely from CMake (but that suggests a broader direction from the project where the headers should be usable without any configuration option).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68075/new/

https://reviews.llvm.org/D68075