[libcxx-commits] [libcxx] r373773 - [libc++] Make the modules-related flags PUBLIC instead of PRIVATE

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Oct 4 12:10:57 PDT 2019


Author: ldionne
Date: Fri Oct  4 12:10:56 2019
New Revision: 373773

URL: http://llvm.org/viewvc/llvm-project?rev=373773&view=rev
Log:
[libc++] Make the modules-related flags PUBLIC instead of PRIVATE

It appears that those need to be propagated to targets that use libc++
as well, otherwise they don't build properly.

Modified:
    libcxx/trunk/CMakeLists.txt

Modified: libcxx/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/CMakeLists.txt?rev=373773&r1=373772&r2=373773&view=diff
==============================================================================
--- libcxx/trunk/CMakeLists.txt (original)
+++ libcxx/trunk/CMakeLists.txt Fri Oct  4 12:10:56 2019
@@ -679,8 +679,8 @@ endif()
 function(cxx_add_module_flags target)
   if (LLVM_ENABLE_MODULES)
     # Ignore that the rest of the modules flags are now unused.
-    target_add_compile_flags_if_supported(${target} PRIVATE -Wno-unused-command-line-argument)
-    target_compile_options(${target} PRIVATE -fno-modules)
+    target_add_compile_flags_if_supported(${target} PUBLIC -Wno-unused-command-line-argument)
+    target_compile_options(${target} PUBLIC -fno-modules)
   endif()
 endfunction()
 




More information about the libcxx-commits mailing list