[libcxx-commits] [PATCH] D68269: [libc++abi] Do not define new/delete by default

[Dimitry Andric via Phabricator via libcxx-commits]

dim added a subscriber: emaste.
dim added a comment.

In D68269#1691913 <https://reviews.llvm.org/D68269#1691913>, @ldionne wrote:

> Pinging vendors for awareness of the change: @phosek @danalbert @dim
>
> This is going in soon and will require a change in how you build libc++abi if you need new/delete definitions to be provided in `libc++abi.so`, namely to use `-DLIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS=ON` when you configure CMake for libc++abi.
>
> The upshot of this change is that by default, we won't get both definitions in libc++ and libc++abi, thus unbreaking the default configuration.


Hm, we don't use libc++abi in FreeBSD (at least not by default), but libcxxrt, which has its own new/delete definitions.  I never noticed a conflict with libc++ though, since when is it providing new/delete by itself?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68269/new/

https://reviews.llvm.org/D68269