[libcxx-commits] [PATCH] D68275: [libcxx] [test] Query the target platform, not the host one

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb added a comment.

In D68275#1690163 <https://reviews.llvm.org/D68275#1690163>, @arichardson wrote:

> Looks good to me but I'm not sure about the PATH changes.
>
> This patch reminds me that I have lots of local changes in the CHERI version of libc++ to improve running tests on a remote platform via SSH. I'll try to upload them soon.


I think it would be a huge help, because running libc++ tests on a remote target is exactly what I'm trying to accomplish.

I've addressed the `PATH` issue.



================
Comment at: libcxx/utils/libcxx/test/config.py:1208
         else:
-            split_char = ';' if self.is_windows else ':'
+            split_char = ';' if self.target_info.is_windows() else ':'
             dest_env['PATH'] = '%s%s%s' % (new_path, split_char,
----------------
ldionne wrote:
> Are you sure this is right? This relates to the platform where the lit tests are going to run, which is the current platform and not necessarily the target, no? Of course, those two have to be compatible but they're not necessarily the same, are they?
I've just looked through the `config.py` file and it seems that this `add_path` method was only ever called on Windows.

But you're right, we probably should ask about the host here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68275/new/

https://reviews.llvm.org/D68275