[libcxx-commits] [PATCH] D68275: [libcxx] [test] Query the target platform, not the host one

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/utils/libcxx/test/config.py:1208
         else:
-            split_char = ';' if self.is_windows else ':'
+            split_char = ';' if self.target_info.is_windows() else ':'
             dest_env['PATH'] = '%s%s%s' % (new_path, split_char,
----------------
Are you sure this is right? This relates to the platform where the lit tests are going to run, which is the current platform and not necessarily the target, no? Of course, those two have to be compatible but they're not necessarily the same, are they?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68275/new/

https://reviews.llvm.org/D68275