[libcxx-commits] [PATCH] D70815: Enable `-funwind-tables` flag when building libunwind

Thu Nov 28 23:47:14 PST 2019

broadwaylamb marked an inline comment as done.
broadwaylamb added inline comments.

================
Comment at: libunwind/CMakeLists.txt:236
+# libunwind quite useless in this setup.
+set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)
+
----------------
smeenai wrote:
> phosek wrote:
> > This option is only available since CMake 3.6, but the minimum requirement for LLVM is 3.4. There's a separate discussion on llvm-dev about bumping that version, but until that happens, this should be behind a condition to avoid breaking users and bots that use CMake 3.4 and 3.5.
> Won't it just end up being a no-op on older CMake version?
> 
> I believe compiler-rt has some custom machinery set up to run compile-only configuration checks. Idk if that's worth trying to replicate here though if we'll be upgrading CMake versions soon anyway.
>Won't it just end up being a no-op on older CMake version?

Agreed, we're just setting a variable here, nothing should go wrong with older versions.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70815/new/

https://reviews.llvm.org/D70815