[libcxx-commits] [PATCH] D70397: [libunwind] Adjust the signal_frame test for Arm
Sergej Jaskiewicz via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Nov 20 06:11:33 PST 2019
broadwaylamb added a comment.
This test won't compile for ARM Linux (using ARM EHABI), I get the error `this directive must appear between .cfi_startproc and .cfi_endproc directives`.
Adding those directives fixes the error (and the test successfully passes), but I'm not a libunwind expert and not sure whether it's ok. Do you think explicitly adding those directives is appropriate? Does it even make sense to run this test with ARM EHABI enabled?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70397/new/
https://reviews.llvm.org/D70397
More information about the libcxx-commits
mailing list