[libcxx-commits] [libcxx] 9918312 - [libc++] Separate -include and path to the site config file
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Nov 18 13:29:43 PST 2019
Author: Louis Dionne
Date: 2019-11-18T16:28:53-05:00
New Revision: 991831268285b955dcb459a1ea2a5f4507a33729
URL: https://github.com/llvm/llvm-project/commit/991831268285b955dcb459a1ea2a5f4507a33729
DIFF: https://github.com/llvm/llvm-project/commit/991831268285b955dcb459a1ea2a5f4507a33729.diff
LOG: [libc++] Separate -include and path to the site config file
This apparently breaks weird use cases where the build directory is on
a separate drive. Someone reported that failure to me privately.
I can't remember of a reason for collating the two arguments in the
first place, so I don't think this should break anything.
Added:
Modified:
libcxx/CMakeLists.txt
Removed:
################################################################################
diff --git a/libcxx/CMakeLists.txt b/libcxx/CMakeLists.txt
index fe40954e0bd4..bfbba319d720 100644
--- a/libcxx/CMakeLists.txt
+++ b/libcxx/CMakeLists.txt
@@ -877,7 +877,7 @@ function(cxx_add_config_site target)
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC" OR "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
target_compile_options(${target} PUBLIC "/FI\"${site_config_path}\"")
else()
- target_compile_options(${target} PUBLIC "-include${site_config_path}")
+ target_compile_options(${target} PUBLIC -include "${site_config_path}")
endif()
endif()
endfunction()
More information about the libcxx-commits
mailing list