[libcxx-commits] [PATCH] D69286: I implemented the features listed in this document: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0616r0.pdf and built libc++ using ninja without any errors/warnings. I Also ran the test suite it using `lit` and passed all the unit tests.

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists requested changes to this revision.
mclow.lists added a comment.
This revision now requires changes to proceed.

One feature per patch, please.

You've got at least three different bits of functionality here.

1. Some random Cmake changes (no description)
2. Some changes to forward_list that are wildly out of date.
3. Some changes to `numeric` which look a lot like D61170 <https://reviews.llvm.org/D61170>

**and** you have no tests.



================
Comment at: libcxx/include/forward_list:1505
 template <class _Tp, class _Alloc>
-void
+decltype(auto)
 forward_list<_Tp, _Alloc>::remove(const value_type& __v)
----------------
I don't know what version of `forward_list` you started with, but it's not the current one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69286/new/

https://reviews.llvm.org/D69286