[libcxx-commits] [PATCH] D69882: [libc++] [P0325] Implement to_array from LFTS with updates.
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Nov 14 05:58:57 PST 2019
ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
Except for the nitpick, LGTM.
================
Comment at: libcxx/include/array:501
+ noexcept(is_nothrow_constructible_v<_Tp, _Tp&>)
+ -> array<remove_cv_t<_Tp>, _Size> {
+ static_assert(
----------------
I'll be very nit-picky and ask you to not use `auto -> T` return types, because we don't use it much elsewhere. I know it's valid, I know it's better style when used throughout a codebase, but I think consistency wins here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69882/new/
https://reviews.llvm.org/D69882
More information about the libcxx-commits
mailing list