[libcxx-commits] [PATCH] D69882: [libcxx] Implement P0325: to_array from LFTS with updates.

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added a comment.

I'm still not sure what to do about `noexcept` for `to_array`.
libstdc++ adds `noexcept`: https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/include/std/array#L361
MSVC STL does not add `noexcept`: https://github.com/microsoft/STL/blob/master/stl/inc/array#L429
It seems to be a low-hanging fruit to add `noexcept(is_nothrow_copy_constructible_v<_Tp>)` / `noexcept(is_nothrow_move_constructible_v<_Tp>)`.
What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69882/new/

https://reviews.llvm.org/D69882