[libcxx-commits] [PATCH] D69929: Fix _LIBCPP_HAS_ definitions for Android.

Elliott Hughes via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Nov 6 21:09:22 PST 2019


enh created this revision.
enh added a reviewer: danalbert.
Herald added subscribers: libcxx-commits, christof, srhines.
Herald added a project: libc++.

Android added quick_exit()/at_quick_exit() in API level 21,
aligned_alloc() in API level 28, and timespec_get() in API level 29,
but has the other C11 features at all API levels (since they're basically
just coming from clang directly).

_LIBCPP_HAS_QUICK_EXIT and _LIBCPP_HAS_TIMESPEC_GET already existed,
so we can reuse them. (And use _LIBCPP_HAS_TIMESPEC_GET in a few more
places where _LIBCPP_HAS_C11_FEATURES has been used as a proxy. This
isn't correct for Android.)

_LIBCPP_HAS_ALIGNED_ALLOC is added, to cover aligned_alloc() (obviously).

Add a missing std:: before aligned_alloc in a cstdlib test, and remove a
couple of !defined(_WIN32)s now that we're explicitly testing
TEST_HAS_ALIGNED_ALLOC rather than TEST_HAS_C11_FEATURES.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69929

Files:
  libcxx/include/__config
  libcxx/include/cstdlib
  libcxx/include/ctime
  libcxx/test/std/depr/depr.c.headers/stdlib_h.pass.cpp
  libcxx/test/std/language.support/support.runtime/cstdlib.pass.cpp
  libcxx/test/std/language.support/support.runtime/ctime.pass.cpp
  libcxx/test/std/utilities/time/date.time/ctime.pass.cpp
  libcxx/test/support/test_macros.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69929.228175.patch
Type: text/x-patch
Size: 6915 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20191107/88356a84/attachment.bin>


More information about the libcxx-commits mailing list