[libcxx-commits] [PATCH] D69677: Correctly update isSignalFrame when unwinding the stack via dwarf.

[Sterling Augustine via Phabricator via libcxx-commits]

saugustine added a comment.

In D69677#1736320 <https://reviews.llvm.org/D69677#1736320>, @lhames wrote:

> Looks sane to me, but I'm not a cfi_signal_frame expert.
>
> Do you know the ipBefore == isSignalFrame relationship is true on all platforms?


I think so. The default inside the canonical libunwind on github has it that way, as does the default inside libgcc (unwind-dw2.c). Strangely, inside libgcc several targets override the default implementation of Unwind_GetIPInfo, but all set ipBefore equivalent to isSignalFrame.

So if there is an exception. I don't know what it would be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69677/new/

https://reviews.llvm.org/D69677