[libcxx-commits] [PATCH] D69902: [libunwind] Drop -Wl, -z, defs for SHARED builds.

[Puyan Lotfi via Phabricator via libcxx-commits]

plotfi created this revision.
plotfi added a reviewer: compnerd.
Herald added subscribers: libcxx-commits, christof, mgorny.
Herald added a project: libc++.
compnerd added a comment.
Herald added a reviewer: mclow.lists.

Can you please write a more complete commit message explaining the need for this.

As an aside for the review itself, could you please enumerate what symbols are unresolved and why they are unresolved.


plotfi added a comment.

In D69902#1735678 <https://reviews.llvm.org/D69902#1735678>, @compnerd wrote:

> Can you please write a more complete commit message explaining the need for this.
>
> As an aside for the review itself, could you please enumerate what symbols are unresolved and why they are unresolved.


Sure.


Drop -Wl,-z,defs in shared builds of libunwind since during builds of ELF libraries, symbol resolution is incomplete.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69902

Files:
  libunwind/src/CMakeLists.txt


Index: libunwind/src/CMakeLists.txt
===================================================================
--- libunwind/src/CMakeLists.txt
+++ libunwind/src/CMakeLists.txt
@@ -133,6 +133,7 @@
                             "1.0"
                           SOVERSION
                             "1")
+  string(REPLACE "-Wl,-z,defs" "" CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS}")
   list(APPEND LIBUNWIND_BUILD_TARGETS "unwind_shared")
   if (LIBUNWIND_INSTALL_SHARED_LIBRARY)
     list(APPEND LIBUNWIND_INSTALL_TARGETS "unwind_shared")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69902.228080.patch
Type: text/x-patch
Size: 546 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20191106/66c4610a/attachment.bin>