[libcxx-commits] [PATCH] D68275: [libcxx] [test] Query the target platform, not the host one

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 5 08:19:26 PST 2019


ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/utils/libcxx/test/executor.py:12
 
+from pathlib import PurePosixPath
+
----------------
Woops, it looks like this is a new dependency that wasn't there before (or maybe this is Python3 only)? Are you able to remove that dependency? It breaks running the tests on my system (so other systems too, probably):

```
from pathlib import PurePosixPath
ImportError: No module named pathlib
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68275/new/

https://reviews.llvm.org/D68275





More information about the libcxx-commits mailing list