[libcxx-commits] [PATCH] D62760: allocate_shared should call allocator_traits::construct

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 31 16:36:16 PDT 2019


zoecarver created this revision.
zoecarver added reviewers: mclow.lists, EricWF, ldionne.
Herald added subscribers: libcxx-commits, dexonsmith.

This patch updates `allocate_shared` to call `allocator_traits::construct`. Fixes issue 41900 <https://bugs.llvm.org/show_bug.cgi?id=41900>. Based on D62233 <https://reviews.llvm.org/D62233>.

Note: `__shared_ptr_aligned_block` is very similar to `__shared_ptr_array_block` from D62641 <https://reviews.llvm.org/D62641> (but with support for custom pointers).

Currently, I have not transferred the changes so the C++03 overloads. Once this has been reviewed a bit, then I will update those.


Repository:
  rCXX libc++

https://reviews.llvm.org/D62760

Files:
  include/memory
  test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/allocate_shared_construct.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62760.202506.patch
Type: text/x-patch
Size: 8201 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190531/18cac76b/attachment.bin>


More information about the libcxx-commits mailing list