[libcxx-commits] [PATCH] D62566: [libcxx][libcxxabi] Remove the unused CMake checks

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D62566#1521730 <https://reviews.llvm.org/D62566#1521730>, @phosek wrote:

> Does anyone have any opinion on `add_compile_flags_if_supported` vs `check_cxx_compiler_flag` + `append_if`? If not I'm going to land this as is.


I have a strong preference for `add_compile_flags_if_supported` until we have the use case you described above. I'm not saying it's not a good/real use case, just that if we're not taking advantage of it right now, we should just simplify things.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62566/new/

https://reviews.llvm.org/D62566