[libcxx-commits] [PATCH] D62090: [runtimes] Support ELF dependent libraries feature

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

It's not entirely clear to me that adding an option to control this is better than just doing it unconditionally. Have you run into a scenario where you didn't want to enable it (and if so, why?).

If that's "just in case", I'd suggest doing it unconditionally and adding an option later if a vendor wants to disable it.



================
Comment at: libcxx/CMakeLists.txt:547
+if (LIBCXX_ENABLE_DEPENDENT_LIBRARIES)
+  add_definitions(-D_LIBCPP_ENABLE_DEPENDENT_LIBRARIES)
+endif()
----------------
Please use the per-target form. We've done a lot of work to remove global definitions and flags, let's keep working in that direction.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62090/new/

https://reviews.llvm.org/D62090