[libcxx-commits] [PATCH] D62228: Make `vector` unconditionally move elements when exceptions are disabled.

[Duncan P. N. Exon Smith via Phabricator via libcxx-commits]

dexonsmith added a comment.



In D62228#1512483 <https://reviews.llvm.org/D62228#1512483>, @EricWF wrote:

> In D62228#1511999 <https://reviews.llvm.org/D62228#1511999>, @mclow.lists wrote:
>
> > There was a discussion on the mailing list that (to my mind) petered out with no particular conclusion as to whether or not this was a good idea.
>
>
> Louis and I talked more offline and there was some consensus that this minimal change was more acceptable.
>  But if there are additional concerns they can be raised here.


I don't think this should be committed until there is consensus on the direction, and when there's contention the usual forum for establishing consensus is the dev list.  Can you restart the discussion on libcxx-dev, or start a new one there?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62228/new/

https://reviews.llvm.org/D62228